How Should one approach dialogue in a story?

For the nit pickers. im looking for what pitfalls to look out for. as well as markers for good dialogue. Aside from that any pointers will also be greatly appreciated.